feat: implementing sso orchestrator existing configs page #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-sheehan-edx
requested review from
marlonkeating,
adamstankiewicz and
kiram15
alex-sheehan-edx
force-pushed
the
asheehan-edx/ENT-7579
branch
from
96c3c0d
to
d31557b
Compare
marlonkeating
requested changes
Oct 5, 2023
src/components/settings/SettingsSSOTab/NewExistingSSOConfigs.jsx
Outdated
Show resolved
Hide resolved
src/components/settings/SettingsSSOTab/NewExistingSSOConfigs.jsx
Outdated
Show resolved
Hide resolved
alex-sheehan-edx
force-pushed
the
asheehan-edx/ENT-7579
branch
2 times, most recently
from
f1e37ef
to
fb3443c
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1050 +/- ##
==========================================
+ Coverage 83.18% 83.36% +0.17%
==========================================
Files 432 435 +3
Lines 9164 9351 +187
Branches 1875 1951 +76
==========================================
+ Hits 7623 7795 +172
- Misses 1499 1513 +14
- Partials 42 43 +1
☔ View full report in Codecov by Sentry. |
marlonkeating
requested changes
Oct 6, 2023
src/components/settings/SettingsSSOTab/NewExistingSSOConfigs.jsx
Outdated
Show resolved
Hide resolved
alex-sheehan-edx
force-pushed
the
asheehan-edx/ENT-7579
branch
2 times, most recently
from
d6119b3
to
2efe326
Compare
alex-sheehan-edx
force-pushed
the
asheehan-edx/ENT-7579
branch
6 times, most recently
from
eda8e4e
to
a77bca4
Compare
alex-sheehan-edx
force-pushed
the
asheehan-edx/ENT-7579
branch
from
a77bca4
to
b71bdff
Compare
marlonkeating
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://2u-internal.atlassian.net/browse/ENT-7579
information on rendering elements based on states of configs: https://docs.google.com/spreadsheets/d/1DKIkXohDWJ3OkuMNAkvoG_9RGjSD_SAA_5cU7oBQ9j4/edit#gid=0
For all changes
Only if submitting a visual change